Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 3608011: Simplify powers-of-ten cache. (Closed)

Created:
10 years, 2 months ago by Florian Loitsch
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Simplify powers-of-ten cache. The existing cache was build to support changes to fast-dtoa. This complicated the cache. Since the cached numbers are now in a .cc file they can be shared with other parts of v8. Committed: http://code.google.com/p/v8/source/detail?r=5606

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -2546 lines) Patch
M src/SConscript View 1 chunk +1 line, -0 lines 0 comments Download
M src/cached-powers.h View 1 chunk +4 lines, -80 lines 0 comments Download
A src/cached-powers.cc View 1 chunk +152 lines, -0 lines 0 comments Download
M src/fast-dtoa.cc View 2 chunks +14 lines, -4 lines 0 comments Download
D src/powers-ten.h View 1 chunk +0 lines, -2461 lines 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Florian Loitsch
10 years, 2 months ago (2010-10-06 19:03:05 UTC) #1
William Hesse
10 years, 2 months ago (2010-10-07 11:15:17 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698