Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 3608004: chromium-overlay: Add sys-apps/pv (pipeline viewer) to dev tools (Closed)

Created:
10 years, 2 months ago by Hung-Te
Modified:
9 years, 7 months ago
Reviewers:
Kenneth Waters, anush
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, tedbo, adlr
Visibility:
Public.

Description

chromium-overlay: Add sys-apps/pv (pipeline viewer) to dev tools pv can provide good progress report when we're dumping to USB. ref: http://codereview.chromium.org/3581007 BUG=none TEST=1. execute src/scripts/build_packages and check pv is emerged into host environment PATH. 2. created a new chroot and checked pv exists in PATH. Change-Id: I0c92901708829edaa45bb6d704ed61288d4b8c1e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, --1 lines) Patch
M chromeos-base/hard-host-depends/hard-host-depends-0.0.1.ebuild View 1 chunk +1 line, -0 lines 0 comments Download
A + chromeos-base/hard-host-depends/hard-host-depends-0.0.1-r66.ebuild View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Hung-Te
10 years, 2 months ago (2010-10-01 12:09:21 UTC) #1
Kenneth Waters
+anush to make sure hard-host-depenends is reved correctly. Add "chromium-overlay:" or some other package description ...
10 years, 2 months ago (2010-10-01 17:20:53 UTC) #2
Hung-Te
Hi anush, do you think it's OK to add pv to host depends? We can ...
10 years, 2 months ago (2010-10-05 10:03:08 UTC) #3
anush
LGTM. Just send out a PSA saying if you run "image_to_usb" you just run "repo ...
10 years, 2 months ago (2010-10-05 17:13:59 UTC) #4
kliegs
Don't object to this CL, but wanted to make sure you don't remove the conditional ...
10 years, 2 months ago (2010-10-05 17:24:13 UTC) #5
Hung-Te
No, we are not going to remove the "if" because some people may still want ...
10 years, 2 months ago (2010-10-05 17:26:11 UTC) #6
anush
10 years, 2 months ago (2010-10-05 20:53:32 UTC) #7
LGTM

On Tue, Oct 5, 2010 at 10:26 AM, <hungte@chromium.org> wrote:

> No, we are not going to remove the "if" because some people may still want
> to
> run image_to_usb outside the chroot. It's discussed and confirmed in
> 3581007.
>
>
> http://codereview.chromium.org/3608004/show
>

Powered by Google App Engine
This is Rietveld 408576698