Add ctest that calls the au test harness.

Add ctest that calls the au test harness.

Change-Id: Ief14528b7e98d792da4be39976ff0fe48219f93b

BUG=6913
TEST=Ran image_to_vm, cros_au_test_harness, and ctest using internal urls.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=2cc5cd4

[sosa, 2010-10-05 05:42:12]

Was other CL sent yesterday.  This new CL is external, has unit tests, and has
been well-tested by me.

I have also fixed an issue in cros_make_image_bootable where old images (before
kwaters CL) still had arm_extra_bootargs option.  Unfortunately, this has a side
affect where devs who use other built images can not mod it for test or VM.  

I left a TODO to remove this later.

[scottz, 2010-10-05 18:17:00]

Awsesome that it moved into crosutils :) 

I am not sure if codereview is just being lame or if you have a write buffer
replace happening but there were a lot of instances where spaces existed where
they shouldn't.

Nice unittests!

http://codereview.chromium.org/3606008/diff/2001/3003
File bin/ctest.py (right):

http://codereview.chromium.org/3606008/diff/2001/3003#newcode107
bin/ctest.py:107: Info('Using cached % s' % image_name)
space: % s

http://codereview.chromium.org/3606008/diff/2001/3003#newcode111
bin/ctest.py:111: Info('Downloading % s' % zip_url)
% s? 

%s

http://codereview.chromium.org/3606008/diff/2001/3003#newcode112
bin/ctest.py:112: RunCommand(['rm', ' - rf', download_folder], print_cmd=False)
spaces here? You just want rm -rf right?

http://codereview.chromium.org/3606008/diff/2001/3003#newcode117
bin/ctest.py:117: # decryption is really slow.
extraction?

http://codereview.chromium.org/3606008/diff/2001/3003#newcode118
bin/ctest.py:118: Info('Unzipping image % s' % image_name)
spaces % s?

http://codereview.chromium.org/3606008/diff/2001/3003#newcode119
bin/ctest.py:119: RunCommand(['unzip', ' - d', download_folder, zip_path],
spaces around - d?

http://codereview.chromium.org/3606008/diff/2001/3003#newcode120
bin/ctest.py:120: print_cmd=False, error_message='Failed to download % s' %
zip_url)
% s? 
more than 80 characters

http://codereview.chromium.org/3606008/diff/2001/3003#newcode166
bin/ctest.py:166: help='channel for the image to  compare against.')
two spaces between "to  compare"

http://codereview.chromium.org/3606008/diff/2001/3003#newcode174
bin/ctest.py:174: (options, sys.argv) = parser.parse_args(sys.argv)
How is the sys.argv passed to the unittests here? I am a little confused by this
operation and I am not entirely a fan of modifying sys.argv.

http://codereview.chromium.org/3606008/diff/2001/3003#newcode190
bin/ctest.py:190: return 0
not necessary the None return will become a 0 and you don't return anything else
anywhere in the code base.

http://codereview.chromium.org/3606008/diff/2001/3003#newcode194
bin/ctest.py:194: sys.exit(main())
sys.exit isn't really necessary here.

[sosa, 2010-10-05 19:29:46]

Sorry Eclipse blunder with the ' % s'.  I figured out what it is ... since I
have auto-fix style whenever I save ... if I have a broken open / close quote
... it assumes the next strings aren't strings and treats % as an operation
where a space would be needed before and after.  I'll probably turn off
auto-correct as this keep biting me.  Thanks for catching this again.

http://codereview.chromium.org/3606008/diff/2001/3003
File bin/ctest.py (right):

http://codereview.chromium.org/3606008/diff/2001/3003#newcode107
bin/ctest.py:107: Info('Using cached % s' % image_name)
On 2010/10/05 18:17:00, scottz wrote:
> space: % s 

Done.

http://codereview.chromium.org/3606008/diff/2001/3003#newcode111
bin/ctest.py:111: Info('Downloading % s' % zip_url)
On 2010/10/05 18:17:00, scottz wrote:
> % s? 
> 
> %s

Done.

http://codereview.chromium.org/3606008/diff/2001/3003#newcode112
bin/ctest.py:112: RunCommand(['rm', ' - rf', download_folder], print_cmd=False)
On 2010/10/05 18:17:00, scottz wrote:
> spaces here? You just want rm -rf right? 

Done.

http://codereview.chromium.org/3606008/diff/2001/3003#newcode117
bin/ctest.py:117: # decryption is really slow.
On 2010/10/05 18:17:00, scottz wrote:
> extraction?

Done.

http://codereview.chromium.org/3606008/diff/2001/3003#newcode118
bin/ctest.py:118: Info('Unzipping image % s' % image_name)
On 2010/10/05 18:17:00, scottz wrote:
> spaces % s? 

Done.

http://codereview.chromium.org/3606008/diff/2001/3003#newcode119
bin/ctest.py:119: RunCommand(['unzip', ' - d', download_folder, zip_path],
On 2010/10/05 18:17:00, scottz wrote:
> spaces around - d? 

Done.

http://codereview.chromium.org/3606008/diff/2001/3003#newcode120
bin/ctest.py:120: print_cmd=False, error_message='Failed to download % s' %
zip_url)
On 2010/10/05 18:17:00, scottz wrote:
> % s? 
> more than 80 characters

Done.

http://codereview.chromium.org/3606008/diff/2001/3003#newcode166
bin/ctest.py:166: help='channel for the image to  compare against.')
On 2010/10/05 18:17:00, scottz wrote:
> two spaces between "to  compare"

Done.

http://codereview.chromium.org/3606008/diff/2001/3003#newcode174
bin/ctest.py:174: (options, sys.argv) = parser.parse_args(sys.argv)
Sorry this is copied originally from cros_au_test_harness where I used unit
tests to test images.  As a point of reference unit tests (run any python unit
test with -h) have their own options that they parse after you can
unittest.main().  So if you have extra args you have to parse them out first
before calling unittest.main()

On 2010/10/05 18:17:00, scottz wrote:
> How is the sys.argv passed to the unittests here? I am a little confused by
this
> operation and I am not entirely a fan of modifying sys.argv.

http://codereview.chromium.org/3606008/diff/2001/3003#newcode190
bin/ctest.py:190: return 0
On 2010/10/05 18:17:00, scottz wrote:
> not necessary the None return will become a 0 and you don't return anything
else
> anywhere in the code base. 

Done.

http://codereview.chromium.org/3606008/diff/2001/3003#newcode194
bin/ctest.py:194: sys.exit(main())
On 2010/10/05 18:17:00, scottz wrote:
> sys.exit isn't really necessary here. 

Done.

[sosa, 2010-10-06 17:36:34]

Ping

[scottz-goog, 2010-10-06 21:26:46]

LGTM