Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Unified Diff: base/logging.cc

Issue 3606003: Revert 61127 - Made logging macros evaluate its stream arguments lazily.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/logging.h ('k') | base/logging_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/logging.cc
===================================================================
--- base/logging.cc (revision 61128)
+++ base/logging.cc (working copy)
@@ -561,9 +561,8 @@
}
LogMessage::~LogMessage() {
- // The macros in logging.h should already avoid creating LogMessages
- // when this holds, but it's possible that users create LogMessages
- // directly (e.g., using LOG_STREAM() directly).
+ // TODO(brettw) modify the macros so that nothing is executed when the log
+ // level is too high.
if (severity_ < min_log_level)
return;
« no previous file with comments | « base/logging.h ('k') | base/logging_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698