Issue 3606003: Revert 61127 - Made logging macros evaluate its stream arguments lazily....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3606003: Revert 61127 - Made logging macros evaluate its stream arguments lazily.... (Closed)

Created:
10 years, 2 months ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
akalin

CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 61127 - Made logging macros evaluate its stream arguments lazily. Also added logging unittests. BUG=57383 TEST=logging_unittest.cc Review URL: http://codereview.chromium.org/3575008 TBR=akalin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61129

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+186 lines, -259 lines)			Patch
M	base/base.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	base/leak_tracker.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/logging.h	View	8 chunks	+183 lines, -143 lines	0 comments	Download
M	base/logging.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
D	base/logging_unittest.cc	View	1 chunk	+0 lines, -111 lines	0 comments	Download

Total messages: 1 (0 generated)