Issue 3604011: AU update generator script: support for new style full updates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3604011: AU update generator script: support for new style full updates (Closed)

Created:
10 years, 2 months ago by adlr

Modified:
9 years ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@chromiumos-git/crosutils.git

Visibility:
Public.

Description

AU update generator script: support for new style full updates A corresponding CL adds support for the delta generator to generate new style full updates. This CL adds support for creating new style full updates to the common update payload generator script. This does not change the defaults, so generating a full update still uses the old style. BUG=7248 TEST=generated/applied full update on host Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=45c24df

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix for review #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -20 lines)			Patch
	M	cros_generate_update_payload	View	1	3 chunks	+33 lines, -20 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

10 years, 2 months ago (2010-10-07 04:23:35 UTC) #2

LGTM

http://codereview.chromium.org/3604011/diff/1/2
File cros_generate_update_payload (right):

http://codereview.chromium.org/3604011/diff/1/2#newcode193
cros_generate_update_payload:193: SRC_MNT=$(mktemp -d /tmp/src_root.XXXXXX)
You could move this code down into the "then" block below.

Expand Messages | Collapse Messages