Issue 3603014: Reapply 61613 that was reverted for false valgrind alarm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3603014: Reapply 61613 that was reverted for false valgrind alarm. (Closed)

Created:
10 years, 2 months ago by kinuko

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr., ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Visibility:
Public.

Description

Reapply 61613 that was reverted for false valgrind alarm. Original issue: http://codereview.chromium.org/3567012/show BUG=none TEST=FileSystemOperationTest.* TBR=ericu,thestig Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61771

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+325 lines, -129 lines)			Patch
M	base/file_util_proxy.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	base/file_util_proxy.cc	View		5 chunks	+68 lines, -57 lines	0 comments	Download
M	base/platform_file.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/file_system/file_system_dispatcher_host.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/file_system/file_system_dispatcher_host.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/common/file_system/file_system_dispatcher.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/file_system/file_system_dispatcher.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/file_system/webfilesystem_impl.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/file_system/webfilesystem_impl.cc	View		2 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/common/render_messages_internal.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/renderer/pepper_plugin_delegate_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/blob/deletable_file_reference.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/fileapi/file_system_operation.h	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	webkit/fileapi/file_system_operation.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	webkit/fileapi/file_system_operation_unittest.cc	View	1 2	15 chunks	+207 lines, -51 lines	0 comments	Download
M	webkit/glue/webkit_glue.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/simple_file_system.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/simple_file_system.cc	View		1 chunk	+8 lines, -1 line	0 comments	Download