Support run multiple control file under the same test directory.

Support run multiple control file under the same test directory.

Change-Id: I1ad0aaec6517758812bf4ba0460ab0c81a6f84cb

BUG=7357
TEST=run_remote_tests.sh ... bvt regression and then observer both bvt and regression test result

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4751889

[petkov, 2010-10-05 22:18:23]

http://codereview.chromium.org/3603012/diff/2001/3001
File run_remote_tests.sh (right):

http://codereview.chromium.org/3603012/diff/2001/3001#newcode242
run_remote_tests.sh:242: short_name=${short_name}.${control_file_name}
why not keep the original short_name in this case? i.e,

testName/control -> testName

[ericli, 2010-10-05 23:27:05]

http://codereview.chromium.org/3603012/diff/2001/3001
File run_remote_tests.sh (right):

http://codereview.chromium.org/3603012/diff/2001/3001#newcode242
run_remote_tests.sh:242: short_name=${short_name}.${control_file_name}
In rare situation, if there are two control files under the same test dir which
neither start with "control.", your suggestion would cause the same result
directory collision, which is the trouble we try to address in this CL.


On 2010/10/05 22:18:24, petkov wrote:
> why not keep the original short_name in this case? i.e,
> 
> testName/control -> testName
> 
>

[petkov, 2010-10-06 12:53:33]

http://codereview.chromium.org/3603012/diff/2001/3001
File run_remote_tests.sh (right):

http://codereview.chromium.org/3603012/diff/2001/3001#newcode242
run_remote_tests.sh:242: short_name=${short_name}.${control_file_name}
How about another special case then, so that:

testName/control -> testName
testName/control.something -> testName.something
testName/some_control -> testName.some_control

If this works, can you also remove the individual comments and just show the
rename examples before the if statement.

On 2010/10/05 23:27:05, ericli wrote:
> In rare situation, if there are two control files under the same test dir
which
> neither start with "control.", your suggestion would cause the same result
> directory collision, which is the trouble we try to address in this CL.
> 
> 
> On 2010/10/05 22:18:24, petkov wrote:
> > why not keep the original short_name in this case? i.e,
> > 
> > testName/control -> testName
> > 
> > 
> 
>

[ericli, 2010-10-06 16:39:45]

PTAL. Thanks.

http://codereview.chromium.org/3603012/diff/2001/3001
File run_remote_tests.sh (right):

http://codereview.chromium.org/3603012/diff/2001/3001#newcode242
run_remote_tests.sh:242: short_name=${short_name}.${control_file_name}
Done.

On 2010/10/06 12:53:34, petkov wrote:
> How about another special case then, so that:
> 
> testName/control -> testName
> testName/control.something -> testName.something
> testName/some_control -> testName.some_control
> 
> If this works, can you also remove the individual comments and just show the
> rename examples before the if statement.
> 
> On 2010/10/05 23:27:05, ericli wrote:
> > In rare situation, if there are two control files under the same test dir
> which
> > neither start with "control.", your suggestion would cause the same result
> > directory collision, which is the trouble we try to address in this CL.
> > 
> > 
> > On 2010/10/05 22:18:24, petkov wrote:
> > > why not keep the original short_name in this case? i.e,
> > > 
> > > testName/control -> testName
> > > 
> > > 
> > 
> > 
> 
>

[petkov, 2010-10-06 16:43:45]

LGTM -- although I would have removed the interleaved comments and have one
summary comment before the whole if.

[ericli, 2010-10-06 17:11:50]

I will take your advice. Changes made, and pushing.