StackTrace should provide access to //@ sourceURL=... value

src/top.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 367 matching lines @@
       }
       SetProperty(stackFrame, line_key,
                   Handle<Smi>(Smi::FromInt(line_number + 1)), NONE);
     }
 
     if (options & StackTrace::kScriptName) {
       Handle<Object> script_name(script->name());
       SetProperty(stackFrame, script_key, script_name, NONE);
     }
 
+    if (options & StackTrace::kScriptNameOrSourceURL) {
+      Handle<Object> script_name(script->name());
+      Handle<String> method_name =

[Vitaly Repeshko, 2010/10/05 10:21:43]

To be consistent with existing column_key, line_key, etc. you might want to
extract the symbol lookup out of the loop.

+          Factory::LookupAsciiSymbol("nameOrSourceURL");
+      Handle<JSValue> script_wrapper = GetScriptWrapper(Handle<Script>(script));

[Vitaly Repeshko, 2010/10/05 10:21:43]

Hmm, the script handle should have been created much earlier. Most other locals
are handles, so we risk using an old raw pointer here.

+      Handle<Object> property = GetProperty(script_wrapper, method_name);
+      ASSERT(property->IsJSFunction());
+      Handle<JSFunction> method = Handle<JSFunction>::cast(property); 
+      bool caught_exception;
+      Handle<Object> result = Execution::TryCall(method, script_wrapper, 0,
+                                                 NULL, &caught_exception);
+      if (caught_exception) {
+        result = Factory::undefined_value();
+      }
+      Handle<String> script_name_or_source_url_key =
+          Factory::LookupAsciiSymbol("scriptNameOrSourceURL");
+      SetProperty(stackFrame, script_name_or_source_url_key, result, NONE);
+    }
+
     if (options & StackTrace::kFunctionName) {
       Handle<Object> fun_name(fun->shared()->name());
       if (fun_name->ToBoolean()->IsFalse()) {
         fun_name = Handle<Object>(fun->shared()->inferred_name());
       }
       SetProperty(stackFrame, function_key, fun_name, NONE);
     }
 
     if (options & StackTrace::kIsEval) {
       int type = Smi::cast(script->compilation_type())->value();
@@ skipping 622 matching lines @@
   Top::break_access_->Lock();
 }
 
 
 ExecutionAccess::~ExecutionAccess() {
   Top::break_access_->Unlock();
 }
 
 
 } }  // namespace v8::internal