Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 3602007: Fix a pair of compilation failure bugs in test files due to r5576. (Closed)

Created:
10 years, 2 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Fix a pair of compilation failure bugs in test files due to r5576. 1. parser.h depends on ast.h, but only gets it included implicitly everywhere parser.h is included (except for tests). Include ast.h in parser.h. 2. Regular expression tests test the free functions that have just been moved into class Parser. TBR=fschneider@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=5577

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M src/parser.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-regexp.cc View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Kevin Millikin (Chromium)
10 years, 2 months ago (2010-10-01 15:31:44 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698