Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: src/strtod.cc

Issue 3601018: Fix new strtod on Windows platform, using OS::SNPrintF instead of snprintf. ... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 22 matching lines...) Expand all
33 #include "strtod.h" 33 #include "strtod.h"
34 // #include "cached-powers.h" 34 // #include "cached-powers.h"
35 35
36 namespace v8 { 36 namespace v8 {
37 namespace internal { 37 namespace internal {
38 38
39 extern "C" double gay_strtod(const char* s00, const char** se); 39 extern "C" double gay_strtod(const char* s00, const char** se);
40 40
41 double strtod(Vector<char> buffer, int exponent) { 41 double strtod(Vector<char> buffer, int exponent) {
42 char gay_buffer[1024]; 42 char gay_buffer[1024];
43 Vector<char> gay_buffer_vector(gay_buffer, sizeof(gay_buffer));
43 buffer.start()[buffer.length()] = '\0'; 44 buffer.start()[buffer.length()] = '\0';
44 snprintf(gay_buffer, 1024, "%se%d", buffer.start(), exponent); 45 OS::SNPrintF(gay_buffer_vector, "%se%d", buffer.start(), exponent);
45 return gay_strtod(gay_buffer, NULL); 46 return gay_strtod(gay_buffer, NULL);
46 } 47 }
47 48
48 } } // namespace v8::internal 49 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698