Issue 3601014: cros_boot_mode: make cros_debug bootloader argument prempt others

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3601014: cros_boot_mode: make cros_debug bootloader argument prempt others (Closed)

Created:
10 years, 2 months ago by Will Drewry

Modified:
9 years, 7 months ago

Reviewers:
fes

CC:
chromium-os-reviews_chromium.org

Base URL:
http://git.chromium.org/git/cros_boot_mode.git

Visibility:
Public.

Description

cros_boot_mode: make cros_debug bootloader argument prempt others cros_debug was meant to be a replacement for cros_* to force developer mode behavior - such as on legacy firmware. However, the easiest way to do so without modifying a file is to add the argument to the bootloader during boot. With syslinux, it is appended. That means that a cros_legacy commandline will have cros_debug appended. Since order matters, moving cros_debug up the chain allows it to preempt any other values. BUG=chromium-os:824 TEST=unittests

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -7 lines)			Patch
M	bootloader_type.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	bootloader_type.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	bootloader_type_unittest.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages