Issue 360053: Change the special handling of typeof comparisons to strings for...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 360053: Change the special handling of typeof comparisons to strings for... (Closed)

Created:
11 years, 1 month ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Change the special handling of typeof comparisons to strings for regular expressions to be consistent with typeof in other contexts. Typeof regular expressions should now be 'function' in all contexts. In the JS natives, IS_FUNCTION, IS_OBJECT, and IS_REGEXP return the same answers as before. Committed: http://code.google.com/p/v8/source/detail?r=3231

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -12 lines)			Patch
M	src/arm/codegen-arm.cc	View	1 chunk	+13 lines, -6 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	src/macros.py	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	test/mjsunit/mjsunit.js	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

11 years, 1 month ago (2009-11-05 15:53:56 UTC) #2

LGTM

http://codereview.chromium.org/360053/diff/1/4
File src/ia32/fast-codegen-ia32.cc (right):

http://codereview.chromium.org/360053/diff/1/4#newcode88
Line 88: // Possibly allocate a local context.
Accidental edit?  Remove.

http://codereview.chromium.org/360053/diff/1/6
File src/x64/fast-codegen-x64.cc (right):

http://codereview.chromium.org/360053/diff/1/6#newcode88
Line 88: // Possibly allocate a local context.
Accidental edit? Remove.

Expand Messages | Collapse Messages