First patch in making destructors of refcounted objects private.

media/base/factory.h

Index: media/base/factory.h
===================================================================
--- media/base/factory.h	(revision 30973)
+++ media/base/factory.h	(working copy)
@@ -93,6 +93,8 @@
   }
 
  private:
+  ~FilterFactoryCollection() {}

[M-A Ruel, 2009/11/05 20:31:28]

virtual

[jam, 2009/11/05 21:52:37]

no child classes.  if they get added in the future, they'll get a compile time
error and can mark this as non-virtual.  before there was no destructor
specified anyways, so this matches the same behavior

+
   typedef std::vector< scoped_refptr<FilterFactory> > FactoryVector;
   FactoryVector factories_;
 
@@ -123,6 +125,8 @@
   }
 
  private:
+  ~FilterFactoryImpl0() {}

[M-A Ruel, 2009/11/05 20:31:28]

virtual

+
   DISALLOW_COPY_AND_ASSIGN(FilterFactoryImpl0);
 };
 
@@ -152,6 +156,8 @@
   }
 
  private:
+   ~FilterFactoryImpl1() {}
+
   A const a_;
   DISALLOW_COPY_AND_ASSIGN(FilterFactoryImpl1);
 };
@@ -173,6 +179,8 @@
   }
 
  private:
+  ~FilterFactoryImpl2() {}
+
   A const a_;
   B const b_;
 
@@ -214,6 +222,8 @@
   }
 
  private:
+  ~InstanceFilterFactory() {}
+
   scoped_refptr<Filter> filter_;
   bool create_called_;