First patch in making destructors of refcounted objects private.

ipc/ipc_sync_channel.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IPC_IPC_SYNC_SENDER_H__
 #define IPC_IPC_SYNC_SENDER_H__
 
 #include <string>
 #include <deque>
 
@@ skipping 43 matching lines @@
   // can be deleted while it's being used in a different thread.  See
   // ChannelProxy::Context for more information.
   class SyncContext : public Context,
                       public base::WaitableEventWatcher::Delegate {
    public:
     SyncContext(Channel::Listener* listener,
                 MessageFilter* filter,
                 MessageLoop* ipc_thread,
                 base::WaitableEvent* shutdown_event);
 
-    ~SyncContext();
-
     // Adds information about an outgoing sync message to the context so that
     // we know how to deserialize the reply.
     void Push(IPC::SyncMessage* sync_msg);
 
     // Cleanly remove the top deserializer (and throw it away).  Returns the
     // result of the Send call for that message.
     bool Pop();
 
     // Returns an event that's set when the send is complete, timed out or the
     // process shut down.
@@ skipping 14 matching lines @@
     // times out.
     void OnSendTimeout(int message_id);
 
     base::WaitableEvent* shutdown_event() { return shutdown_event_; }
 
     ReceivedSyncMsgQueue* received_sync_msgs() {
       return received_sync_msgs_;
     }
 
    private:
+    ~SyncContext();

[M-A Ruel, 2009/11/05 20:31:28]

virtual

[jam, 2009/11/05 21:52:37]

no need, nothing derives from this class.

[awong, 2009/11/05 21:58:39]

It's already virtual because it's inheriting from a class that has a virtual
destructor.  Making it virtual here is just good documentation.  (Also the style
guide says to. :) )

Same with the other childless classes that are descendants of others with
virtual destructors.

     // IPC::ChannelProxy methods that we override.
 
     // Called on the listener thread.
    virtual void Clear();

[M-A Ruel, 2009/11/05 20:31:28]

please fix alignment while at it.

[jam, 2009/11/05 21:52:37]

Done.

 
     // Called on the IPC thread.
     virtual void OnMessageReceived(const Message& msg);
     virtual void OnChannelError();
     virtual void OnChannelOpened();
     virtual void OnChannelClosed();
 
     // Cancels all pending Send calls.
     void CancelPendingSends();
 
@@ skipping 42 matching lines @@
 
   // Used to signal events between the IPC and listener threads.
   base::WaitableEventWatcher dispatch_watcher_;
 
   DISALLOW_EVIL_CONSTRUCTORS(SyncChannel);
 };
 
 }  // namespace IPC
 
 #endif  // IPC_IPC_SYNC_SENDER_H__