First patch in making destructors of refcounted objects private.

ipc/file_descriptor_set_posix.h

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IPC_FILE_DESCRIPTOR_SET_POSIX_H_
 #define IPC_FILE_DESCRIPTOR_SET_POSIX_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/file_descriptor_posix.h"
 #include "base/ref_counted.h"
 
 // -----------------------------------------------------------------------------
 // A FileDescriptorSet is an ordered set of POSIX file descriptors. These are
 // associated with IPC messages so that descriptors can be transmitted over a
 // UNIX domain socket.
 // -----------------------------------------------------------------------------
 class FileDescriptorSet : public base::RefCountedThreadSafe<FileDescriptorSet> {
  public:
   FileDescriptorSet();
-  ~FileDescriptorSet();
 
   // This is the maximum number of descriptors per message. We need to know this
   // because the control message kernel interface has to be given a buffer which
   // is large enough to store all the descriptor numbers. Otherwise the kernel
   // tells us that it truncated the control data and the extra descriptors are
   // lost.
   //
   // In debugging mode, it's a fatal error to try and add more than this number
   // of descriptors to a FileDescriptorSet.
   enum {
@@ skipping 50 matching lines @@
   // Interfaces for receiving...
 
   // Set the contents of the set from the given buffer. This set must be empty
   // before calling. The auto-close flag is set on all the descriptors so that
   // unconsumed descriptors are closed on destruction.
   void SetDescriptors(const int* buffer, unsigned count);
 
   // ---------------------------------------------------------------------------
 
  private:
+  friend class base::RefCountedThreadSafe<FileDescriptorSet>;
+
+  ~FileDescriptorSet();
+
   // A vector of descriptors and close flags. If this message is sent, then
   // these descriptors are sent as control data. After sending, any descriptors
   // with a true flag are closed. If this message has been received, then these
   // are the descriptors which were received and all close flags are true.
   std::vector<base::FileDescriptor> descriptors_;
 
   // This contains the index of the next descriptor which should be consumed.
   // It's used in a couple of ways. Firstly, at destruction we can check that
   // all the descriptors have been read (with GetNthDescriptor). Secondly, we
   // can check that they are read in order.
   mutable unsigned consumed_descriptor_highwater_;
 
   DISALLOW_COPY_AND_ASSIGN(FileDescriptorSet);
 };
 
 #endif  // IPC_FILE_DESCRIPTOR_SET_POSIX_H_