chrome/browser/resources/extensions_ui.html - Issue 360039: Fix bug where we were not displaying icons in the management

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/extensions_ui.html

Issue 360039: Fix bug where we were not displaying icons in the management (Closed)

Patch Set: update test data Created 11 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/extensions_ui.cc ('K') | « chrome/browser/extensions/extensions_ui.cc ('k') | chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <html>	2 <html>

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <title i18n-content="title"></title>	5 <title i18n-content="title"></title>

6 <style>	6 <style>

7 body {	7 body {

8 font-size: 87%;	8 font-size: 87%;

9 font-family: Helvetica, Arial, sans-serif;	9 font-family: Helvetica, Arial, sans-serif;

10 margin: 10px;	10 margin: 10px;

(...skipping 625 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
636 <div class="extension-name" jsdisplay="extensions.length === 0"	636 <div class="extension-name" jsdisplay="extensions.length === 0"

637 i18n-content="noExtensions">NO_EXTENSIONS_ARE_INSTALLED</div>	637 i18n-content="noExtensions">NO_EXTENSIONS_ARE_INSTALLED</div>

638	638

639 <div jsdisplay="extensions.length > 0">	639 <div jsdisplay="extensions.length > 0">

640 <div class="extension" jsselect="extensions">	640 <div class="extension" jsselect="extensions">

641 <table width="100%" cellpadding="2" cellspacing="0">	641 <table width="100%" cellpadding="2" cellspacing="0">

642 <tr jsvalues=".className:enabled ? 'extension_enabled' : 'extension_di sabled'">	642 <tr jsvalues=".className:enabled ? 'extension_enabled' : 'extension_di sabled'">

643 <td width="62" height="50" align="center" valign="top">	643 <td width="62" height="50" align="center" valign="top">

644 <span jsdisplay="icon"	644 <span jsdisplay="icon"

645 ><img	645 ><img

646 jsvalues=".src:'chrome-extension://' + id + '/' + icon"	646 jsvalues=".src:icon"

647 width="48" height="48" />	647 width="48" height="48" />

648 </span>	648 </td>

649 <span jsdisplay="icon == ''"

650 ><img

651 width="48" height="48"

652 src="../../app/theme/infobar_plugin.png" /></span>

653 </td>

654 <td valign="top">	649 <td valign="top">

655 <div>	650 <div>

656 <span class="extension-name"	651 <span class="extension-name"

657 jscontent="name">EXTENSION NAME</span>	652 jscontent="name">EXTENSION NAME</span>

658 <span i18n-content="extensionVersion">VERSION</span>	653 <span i18n-content="extensionVersion">VERSION</span>

659 <span jscontent="version">x.x.x.x</span>	654 <span jscontent="version">x.x.x.x</span>

660 <span jsdisplay="!enabled"	655 <span jsdisplay="!enabled"

661 i18n-content="extensionDisabled">(DISABLED)</span>	656 i18n-content="extensionDisabled">(DISABLED)</span>

662 <span jsdisplay="order == 1"	657 <span jsdisplay="order == 1"

663 i18n-content="inDevelopment">(IN DEVELOPMENT)</span>	658 i18n-content="inDevelopment">(IN DEVELOPMENT)</span>

(...skipping 70 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
734 </td>	729 </td>

735 </tr>	730 </tr>

736 </table>	731 </table>

737 </div>	732 </div>

738 </div>	733 </div>

739 </div>	734 </div>

740 </div>	735 </div>

741 </div>	736 </div>

742 </body>	737 </body>

743 </html>	738 </html>

OLD	NEW