Issue 360024: Remove the sync error button from the Linux bookmark bar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 360024: Remove the sync error button from the Linux bookmark bar. (Closed)

Created:
11 years, 1 month ago by ncarter (slow)

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Remove the sync error button from the Linux bookmark bar. It wasn't wired up to any errors yet, it wasn't hidden by default, it created an unnecessary horizontal space, and it would DCHECK (or worse) when that space was clicked. BUG=26595 TEST=Displayed the bookmarks bar, verified that the gap to the left of "Other Bookmarks" went away and that it was no longer clickable. R=estade Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31011

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -10 lines)			Patch
	M	chrome/browser/gtk/bookmark_bar_gtk.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	chrome/browser/gtk/bookmark_bar_gtk.cc	View		2 chunks	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages