Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1283)

Unified Diff: chrome/browser/gtk/menu_gtk.cc

Issue 360023: GTK: Fix a couple minor popup window icon menu bugs. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/gtk/browser_titlebar.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/menu_gtk.cc
===================================================================
--- chrome/browser/gtk/menu_gtk.cc (revision 30942)
+++ chrome/browser/gtk/menu_gtk.cc (working copy)
@@ -177,14 +177,14 @@
submenus_we_own_.push_back(menu_data->custom_submenu);
}
- if ((menu_data->only_show || accel_group) && menu_data->accel_key) {
+ if (menu_data->accel_key) {
// If we ever want to let the user do any key remaping, we'll need to
// change the following so we make a gtk_accel_map which keeps the actual
// keys.
gtk_widget_add_accelerator(menu_item,
"activate",
- menu_data->only_show ? dummy_accel_group_ :
- accel_group,
+ menu_data->only_show || !accel_group ?
+ dummy_accel_group_ : accel_group,
menu_data->accel_key,
GdkModifierType(menu_data->accel_modifiers),
GTK_ACCEL_VISIBLE);
« no previous file with comments | « chrome/browser/gtk/browser_titlebar.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698