Rework the way we handle the fact that the ARM simulator uses a...

Rework the way we handle the fact that the ARM simulator uses a
separate JS stack.

In exception handling, we need to be able to compare addresses into
the JavaScript portion of the stack with the address of a C++ handler
on the stack.  Since the stacks are separate on the simulator, we need
a JavaScript stack address corresponding to a C++ try catch handler in
order to perform valid address comparisons.

On the simulator, we now link the C++ try catch handlers indirectly
through the JS stack and use the JS stack indirection address for
comparisons.

      JS                    C++
                           
                           handler
 [C++ address]   <------    next_
                \
                 \
                  \---->   handler
 [C++ address]   <------    next_


On actual hardware the C++ try catch handlers continue to be directly
linked.

BUG=http://code.google.com/p/v8/issues/detail?id=271

Committed: http://code.google.com/p/v8/source/detail?r=3228

[iposva, 2009-11-05 12:46:38]

LGTM with nits.

-Ivan

http://codereview.chromium.org/360004/diff/1/10
File src/arm/simulator-arm.h (right):

http://codereview.chromium.org/360004/diff/1/10#newcode146
Line 146: void PopAddress();
I know this is not needed for this implementation, but it would be symmetrical
if PopAddress returned the address which was located on the stack.

http://codereview.chromium.org/360004/diff/1/5
File src/top.cc (right):

http://codereview.chromium.org/360004/diff/1/5#newcode38
Line 38: #endif
Maybe we should have a simulator.h which contains the above code?

http://codereview.chromium.org/360004/diff/1/7
File src/top.h (right):

http://codereview.chromium.org/360004/diff/1/7#newcode53
Line 53: // none are registered.
It is hard to see the distinction from the comment above.

[Mads Ager (chromium), 2009-11-05 13:18:27]

http://codereview.chromium.org/360004/diff/1/10
File src/arm/simulator-arm.h (right):

http://codereview.chromium.org/360004/diff/1/10#newcode146
Line 146: void PopAddress();
On 2009/11/05 12:46:39, iposva wrote:
> I know this is not needed for this implementation, but it would be symmetrical
> if PopAddress returned the address which was located on the stack.

Done.

http://codereview.chromium.org/360004/diff/1/5
File src/top.cc (right):

http://codereview.chromium.org/360004/diff/1/5#newcode38
Line 38: #endif
On 2009/11/05 12:46:39, iposva wrote:
> Maybe we should have a simulator.h which contains the above code?

We should.  Done.

http://codereview.chromium.org/360004/diff/1/7
File src/top.h (right):

http://codereview.chromium.org/360004/diff/1/7#newcode53
Line 53: // none are registered.
On 2009/11/05 12:46:39, iposva wrote:
> It is hard to see the distinction from the comment above.

I have extended the comment for TryCatchHandler in an attempt to make the
distinction clearer.