Issue 3598019: Add ability to vm library to retry until we can ssh into it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3598019: Add ability to vm library to retry until we can ssh into it. (Closed)

Created:
10 years, 2 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

Add ability to vm library to retry until we can ssh into it. Change-Id: I4de388bb1af6cd4568cdc154971927941eb73800 BUG=7503 TEST=Ran test by closing vm's as they start up to see retry work. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3314672

Patch Set 1 #

Total comments: 2

Patch Set 2 : Upload before push #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -4 lines)			Patch
	M	bin/cros_run_vm_test	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
	M	lib/cros_vm_lib.sh	View	1	2 chunks	+36 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

10 years, 2 months ago (2010-10-07 22:52:23 UTC) #2

LGTM w/ a couple of nits.

http://codereview.chromium.org/3598019/diff/1/2
File bin/cros_run_vm_test (right):

http://codereview.chromium.org/3598019/diff/1/2#newcode13
bin/cros_run_vm_test:13: RETRIES=3
MAX_RETRIES?

http://codereview.chromium.org/3598019/diff/1/3
File lib/cros_vm_lib.sh (right):

http://codereview.chromium.org/3598019/diff/1/3#newcode83
lib/cros_vm_lib.sh:83: retries=$((retries + 1 ))
remove space before ))

Expand Messages | Collapse Messages