AU: More graph utilities

AU: More graph utilities

EdgeProperties: support for listing blocks in a write-before
dependency. Blocks historically have only been listed for a
read-before dep. operator== for Extent and EdgeProperties.

Vertex: ability to mark invalid. An invalid vertex is not part of the
graph.

graph utils: Functions to add and drop dependencies.

Overloaded GetElement() to pull an element at a given index from
either a vector<Extent> or RepeatedPtrField<Extent>.

DumpGraph function, useful for debugging.

BUG=none
TEST=unittests

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=1bc16ab

[petkov, 2010-10-06 05:08:33]

LGTM

http://codereview.chromium.org/3596007/diff/1/2
File graph_types.h (right):

http://codereview.chromium.org/3596007/diff/1/2#newcode30
graph_types.h:30: // by the node pointed to before the pointint node runs
(presumably
typo: pointing

http://codereview.chromium.org/3596007/diff/1/2#newcode70
graph_types.h:70: const uint64_t kTempBlockStart =
static_cast<uint64_t>(0x10000000) << 32;
1ULL << 60 or 0x10000000ULL << 32 should work, I think.

http://codereview.chromium.org/3596007/diff/1/3
File graph_utils.cc (right):

http://codereview.chromium.org/3596007/diff/1/3#newcode6
graph_utils.cc:6: #include <string>
add an empty line before

http://codereview.chromium.org/3596007/diff/1/3#newcode9
graph_utils.cc:9: #include <base/basictypes.h>
add an empty line before

http://codereview.chromium.org/3596007/diff/1/3#newcode117
graph_utils.cc:117: // void SetElement(std::vector<Extent>* collection,
Any reason to keep these?

http://codereview.chromium.org/3596007/diff/1/5
File graph_utils_unittest.cc (right):

http://codereview.chromium.org/3596007/diff/1/5#newcode7
graph_utils_unittest.cc:7: #include <gtest/gtest.h>
add an empty line before and after

[adlr, 2010-10-06 22:07:35]

fixed and pushed. thanks!

http://codereview.chromium.org/3596007/diff/1/2
File graph_types.h (right):

http://codereview.chromium.org/3596007/diff/1/2#newcode30
graph_types.h:30: // by the node pointed to before the pointint node runs
(presumably
On 2010/10/06 05:08:33, petkov wrote:
> typo: pointing

Done.

http://codereview.chromium.org/3596007/diff/1/2#newcode70
graph_types.h:70: const uint64_t kTempBlockStart =
static_cast<uint64_t>(0x10000000) << 32;
On 2010/10/06 05:08:33, petkov wrote:
> 1ULL << 60 or 0x10000000ULL << 32 should work, I think.
> 

I was avoiding ULL b/c uint64_t isn't always unsigned long long, but there were
no compiler warning by this change, so fixed.

http://codereview.chromium.org/3596007/diff/1/3
File graph_utils.cc (right):

http://codereview.chromium.org/3596007/diff/1/3#newcode6
graph_utils.cc:6: #include <string>
On 2010/10/06 05:08:33, petkov wrote:
> add an empty line before
> 

Done.

http://codereview.chromium.org/3596007/diff/1/3#newcode9
graph_utils.cc:9: #include <base/basictypes.h>
On 2010/10/06 05:08:33, petkov wrote:
> add an empty line before
> 

Done.

http://codereview.chromium.org/3596007/diff/1/3#newcode117
graph_utils.cc:117: // void SetElement(std::vector<Extent>* collection,
On 2010/10/06 05:08:33, petkov wrote:
> Any reason to keep these?
> 

oops. removed

http://codereview.chromium.org/3596007/diff/1/5
File graph_utils_unittest.cc (right):

http://codereview.chromium.org/3596007/diff/1/5#newcode7
graph_utils_unittest.cc:7: #include <gtest/gtest.h>
On 2010/10/06 05:08:33, petkov wrote:
> add an empty line before and after
> 

Done.