Workaround to disable Progress() on buildbot by disabling it on --verbose.

Workaround to disable Progress() on buildbot by disabling it on --verbose.

sys.stdout.isatty() is True even on buildbot.
Otherwise, logs can't be untangled when using --jobs.

TEST=none
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61552

[Nicolas Sylvain, 2010-10-05 19:13:47]

really weird.

lg for now

On Tue, Oct 5, 2010 at 7:04 AM, <maruel@chromium.org> wrote:

> Reviewers: Nicolas Sylvain,
>
> Description:
> Workaround to disable Progress() on buildbot by disabling it on --verbose.
>
> sys.stdout.isatty() is True even on buildbot.
> Otherwise, logs can't be untangled when using --jobs.
>
> TEST=none
> BUG=none
>
> Please review this at http://codereview.chromium.org/3596006/show
>
> Affected files:
>  M gclient.py
>
>
> Index: gclient.py
> diff --git a/gclient.py b/gclient.py
> index
>
cd269cb669af46cf60a8f91fcae19764cd289288..9cf30c76cb6fb4bb659f71f153549452bca6433e
> 100644
> --- a/gclient.py
> +++ b/gclient.py
> @@ -716,7 +716,8 @@ solutions = [
>     revision_overrides = self._EnforceRevisions()
>     pm = None
>     # Disable progress for non-tty stdout.
> -    if command in ('update', 'revert') and sys.stdout.isatty():
> +    if (command in ('update', 'revert') and sys.stdout.isatty() and not
> +        self._options.verbose):
>       pm = Progress('Syncing projects', 1)
>     work_queue = gclient_utils.ExecutionQueue(self._options.jobs, pm)
>     for s in self.dependencies:
>
>
>