Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 3595015: build_image: fix verity defaults (Closed)

Created:
10 years, 2 months ago by Will Drewry
Modified:
9 years, 7 months ago
Reviewers:
fes
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

build_image: fix verity defaults This changes defaults failure to a panic/recovery reboot and disables the debugging max_bios argument to ensure that we don't trigger race conditions in the kernel during un-protected pending_bio count decrements. (Can lead to a hung-system.) TEST=built x86-generic; ensured -1 and the panic changes worked BUG=chromium-os:6956

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M build_image View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Will Drewry
10 years, 2 months ago (2010-10-06 17:38:58 UTC) #1
fes
10 years, 2 months ago (2010-10-06 19:49:32 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698