Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 3595002: Fine-tune inobject slack tracking.... (Closed)

Created:
10 years, 2 months ago by Vladislav Kaznacheev
Modified:
9 years, 7 months ago
Reviewers:
antonm, Vitaly Repeshko
CC:
v8-dev
Visibility:
Public.

Description

Fine-tune inobject slack tracking. The current parameters (initial slack = 6, kGenerousAllocationsCount = 16) caused 15-20% performance regression on 3d-raytrace on x64 (visible both in standalone shell and in the web harness). This is very likely some kind of an alignment problem (it goes away completely with --prof). A similar problem can be observed on ia32 with initial slack=2. Increased initial slack to 8 and decreased constructions count to 8. This made the regression go away (and did not harm any of the other tests). Committed: http://code.google.com/p/v8/source/detail?r=5571

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/handles.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Vladislav Kaznacheev
10 years, 2 months ago (2010-09-30 12:48:58 UTC) #1
Vitaly Repeshko
10 years, 2 months ago (2010-09-30 17:36:39 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698