D-Bus API: Add GetDataPlans, DataPlansUpdate, and RequestDataPlansUpdate

D-Bus API: Add GetDataPlans, DataPlansUpdate, and RequestDataPlansUpdate

Implement "the real" D-Bus API for use by libcros. Returns hardcoded test data for now.

The related CL for libcros changes is: http://codereview.chromium.org/3578003/show

BUG=chromium-os:3510
TEST=libcros/monitor_network

Change-Id: I50530f90a083f6bdba3ef15c718c43e94e308f50

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=bb6a47a

[Eric Shienbrood, 2010-09-29 22:06:14]

http://codereview.chromium.org/3595001/diff/1/2
File introspection/cashew.xml (right):

http://codereview.chromium.org/3595001/diff/1/2#newcode40
introspection/cashew.xml:40: <arg name="plans" type="aa{sv}" direction="out">
I think there may be some way to factor this and the above similar stanza out
using tp:mapping or something. Not sure about this though.

http://codereview.chromium.org/3595001/diff/1/3
File src/cashew_server.cc (right):

http://codereview.chromium.org/3595001/diff/1/3#newcode86
src/cashew_server.cc:86: CreateDBusVariant<std::string>(plan_name)));
I don't think you need CreateDBusVariant. You should be able to do something
like

DataPlan plan;
*plan["CellularPlanType"].writer().append_string(plan_type);
*plan["CellularPlanUpdateTime"].writer().append_int64(plan_update_time);
...

and I think it'll look better if  you make plan a reference.

[stevenjb, 2010-09-29 23:58:09]

http://codereview.chromium.org/3595001/diff/1/3
File src/cashew_server.cc (right):

http://codereview.chromium.org/3595001/diff/1/3#newcode40
src/cashew_server.cc:40: // limiting prohibits it.
Another note we might want to add to the comment: the request is for up-to-date
data plan info (generally triggered by a user action such as opening a menu or
dialog), so we may want this to trigger a request from a provider, with the
update signal sent when that completes.

[Vince Laviano, 2010-09-30 00:21:44]

http://codereview.chromium.org/3595001/diff/1/2
File introspection/cashew.xml (right):

http://codereview.chromium.org/3595001/diff/1/2#newcode40
introspection/cashew.xml:40: <arg name="plans" type="aa{sv}" direction="out">
On 2010/09/29 22:06:14, Eric Shienbrood wrote:
> I think there may be some way to factor this and the above similar stanza out
> using tp:mapping or something. Not sure about this though.

Done. I decided to use tp:struct because it allows for better documentation of
the individual fields. As far as I can tell from
http://telepathy.freedesktop.org/wiki/DbusSpec#extensions-v0 , tp:mapping only
allows two members and would have looked like:  

member1, type=string, name="Key", desc="The key."
member2, type=variant, name="Value", desc="uh... stuff. <insert long textual
explanation as before>"

PTAL.

http://codereview.chromium.org/3595001/diff/1/3
File src/cashew_server.cc (right):

http://codereview.chromium.org/3595001/diff/1/3#newcode40
src/cashew_server.cc:40: // limiting prohibits it.
On 2010/09/29 23:58:09, Steven Bennetts wrote:
> Another note we might want to add to the comment: the request is for
up-to-date
> data plan info (generally triggered by a user action such as opening a menu or
> dialog), so we may want this to trigger a request from a provider, with the
> update signal sent when that completes.

Done.

http://codereview.chromium.org/3595001/diff/1/3#newcode86
src/cashew_server.cc:86: CreateDBusVariant<std::string>(plan_name)));
On 2010/09/29 22:06:14, Eric Shienbrood wrote:
> I don't think you need CreateDBusVariant. You should be able to do something
> like
> 
> DataPlan plan;
> *plan["CellularPlanType"].writer().append_string(plan_type);
> *plan["CellularPlanUpdateTime"].writer().append_int64(plan_update_time);
> ...
> 

Done and retested.  PTAL.

> and I think it'll look better if  you make plan a reference.

It would, but the Google C++ coding standards require that reference args be
const (i.e., that they be input args) and that output args be pointers.  See the
"Other C++ Features -> Reference Arguments" section.  This is why I have all
those NOLINT comments next to the non-const reference args in my
dbus-c++-generated method signatures.

[Eric Shienbrood, 2010-09-30 22:28:38]

LGTM