Add checking of space permissions and kernel space unique ID

Add checking of space permissions and kernel space unique ID

Change-Id: I7a77a7cd9d51238da314b09b3ac18b9dabeaa610

BUG=6061
TEST=successfully built and ran the autotest

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7bfabc0

[Luigi Semenzato, 2010-10-08 20:31:59]

This completes the TPM sanity check autotest.

[Luigi Semenzato, 2010-10-08 22:48:28]

For more reliable testing, don't fail if running on firmware older than
X.03.60.1117.0036.Y.

(Randall: can we guarantee that the number of digits in the 2nd to 5th positions
will not change?  I.e. can we use lexicographic comparison, or do we have to use
numeric comparisons?  I already know that the 6th position is not always a
number, but we can ignore it in this case.)

[Randall Spangler, 2010-10-08 23:20:59]

http://codereview.chromium.org/3593012/diff/3001/4001
File autotest/client/hardware_TPMCheck/hardware_TPMCheck.py (right):

http://codereview.chromium.org/3593012/diff/3001/4001#newcode17
autotest/client/hardware_TPMCheck/hardware_TPMCheck.py:17: w = re.split("\.",
"any-nickname.03.60.1117.0036.")[1:]
1117 -> 1118

http://codereview.chromium.org/3593012/diff/3001/4001#newcode20
autotest/client/hardware_TPMCheck/hardware_TPMCheck.py:20: for x, y in zip(v,
w):
Since you've checked length, you should just be able to do 
   v >= w
since tuple-comparison compares each item in the tuple in order.

http://codereview.chromium.org/3593012/diff/3001/4001#newcode39
autotest/client/hardware_TPMCheck/hardware_TPMCheck.py:39: utils.system("start
tcsd", ignore_status=True)
Could also put the "start tcsd" in a try-finally in run_once()

try:
  (the rest of your test code after stop tcsd)
finally:
  start tcsd

http://codereview.chromium.org/3593012/diff/3001/4001#newcode58
autotest/client/hardware_TPMCheck/hardware_TPMCheck.py:58: if
old_or_bad_firmware_version():
Should print/log a message like "Skipping TPM test because firmware is too old."
 Otherwise, we might not notice that the test isn't running when it should run
(for example, a new version of firmware has a version string that confuses the
version checker code)

[Luigi Semenzato, 2010-10-11 16:19:15]

Thank you for the excellent suggestions.  PTAL.

On 2010/10/08 23:20:59, Randall Spangler wrote:
> http://codereview.chromium.org/3593012/diff/3001/4001
> File autotest/client/hardware_TPMCheck/hardware_TPMCheck.py (right):
> 
> http://codereview.chromium.org/3593012/diff/3001/4001#newcode17
> autotest/client/hardware_TPMCheck/hardware_TPMCheck.py:17: w = re.split("\.",
> "any-nickname.03.60.1117.0036.")[1:]
> 1117 -> 1118
> 
> http://codereview.chromium.org/3593012/diff/3001/4001#newcode20
> autotest/client/hardware_TPMCheck/hardware_TPMCheck.py:20: for x, y in zip(v,
> w):
> Since you've checked length, you should just be able to do 
>    v >= w
> since tuple-comparison compares each item in the tuple in order.
> 
> http://codereview.chromium.org/3593012/diff/3001/4001#newcode39
> autotest/client/hardware_TPMCheck/hardware_TPMCheck.py:39: utils.system("start
> tcsd", ignore_status=True)
> Could also put the "start tcsd" in a try-finally in run_once()
> 
> try:
>   (the rest of your test code after stop tcsd)
> finally:
>   start tcsd
> 
> http://codereview.chromium.org/3593012/diff/3001/4001#newcode58
> autotest/client/hardware_TPMCheck/hardware_TPMCheck.py:58: if
> old_or_bad_firmware_version():
> Should print/log a message like "Skipping TPM test because firmware is too
old."
>  Otherwise, we might not notice that the test isn't running when it should run
> (for example, a new version of firmware has a version string that confuses the
> version checker code)

[Randall Spangler, 2010-10-11 17:24:04]

LGTM