AU: Verify delta payload signature and signed hash.

AU: Verify delta payload signature and signed hash.

The signature and hash are verified only if the public key file exists.
This means that currently this feature is desabled until we install a public
key.

BUG=5663
TEST=unit tests, applied a signed delta update on the server

Change-Id: I5be72f7fde88400587f8aae0c7d5745c79fc4428

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=d7061ab

[adlr, 2010-10-05 23:22:10]

http://codereview.chromium.org/3592008/diff/8001/9002
File delta_performer.cc (right):

http://codereview.chromium.org/3592008/diff/8001/9002#newcode454
delta_performer.cc:454: CHECK_EQ(buffer_offset_, manifest_.signatures_offset());
maybe test and return false here and the next line?

http://codereview.chromium.org/3592008/diff/8001/9009
File payload_signer.cc (right):

http://codereview.chromium.org/3592008/diff/8001/9009#newcode105
payload_signer.cc:105: TEST_AND_RETURN_FALSE(signatures.signatures_size() == 1);
we may want to have many signatures within the Signatures protobuf, so this code
should iterate and check the 'version' field for kSignatureMessageVersion,
ignoring all the other signature messages

http://codereview.chromium.org/3592008/diff/8001/9012
File unittest_pubkey.pem (right):

http://codereview.chromium.org/3592008/diff/8001/9012#newcode1
unittest_pubkey.pem:1: -----BEGIN PUBLIC KEY-----
can this be generated w/ a scons rule?

[petkov, 2010-10-06 04:36:08]

PTAL. Also renamed the public key.

http://codereview.chromium.org/3592008/diff/8001/9002
File delta_performer.cc (right):

http://codereview.chromium.org/3592008/diff/8001/9002#newcode454
delta_performer.cc:454: CHECK_EQ(buffer_offset_, manifest_.signatures_offset());
On 2010/10/05 23:22:11, adlr wrote:
> maybe test and return false here and the next line?

Done. Although there're other similar cases in this file.

http://codereview.chromium.org/3592008/diff/8001/9009
File payload_signer.cc (right):

http://codereview.chromium.org/3592008/diff/8001/9009#newcode105
payload_signer.cc:105: TEST_AND_RETURN_FALSE(signatures.signatures_size() == 1);
On 2010/10/05 23:22:11, adlr wrote:
> we may want to have many signatures within the Signatures protobuf, so this
code
> should iterate and check the 'version' field for kSignatureMessageVersion,
> ignoring all the other signature messages

Done.

http://codereview.chromium.org/3592008/diff/8001/9012
File unittest_pubkey.pem (right):

http://codereview.chromium.org/3592008/diff/8001/9012#newcode1
unittest_pubkey.pem:1: -----BEGIN PUBLIC KEY-----
On 2010/10/05 23:22:11, adlr wrote:
> can this be generated w/ a scons rule?

Done -- I'm used to Makefiles so I can only hope I did the scons change
correctly (seems to work).

[petkov, 2010-10-06 12:49:37]

Also moved the signature verification temp files to root-only /var/run. We
should really use the openssl library directly here. PTAL.

[adlr, 2010-10-06 21:26:57]

LGTM