Issue 3592001: Undisable download UI tests. We shouldn't leak processes now if they fail.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3592001: Undisable download UI tests. We shouldn't leak processes now if they fail. (Closed)

Created:
10 years, 2 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Bernhard Bauer, TVL

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Undisable download UI tests. We shouldn't leak processes now if they fail. Is flaky better than disabled? Dunno, but it looks better (tm). BUG=35275, 48913, 50060 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61036

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -16 lines)			Patch
	M	chrome/browser/download/download_uitest.cc	View		15 chunks	+16 lines, -16 lines	0 comments	Download

Total messages: 4 (0 generated)

Paweł Hajdan Jr.

Some context: it turns out that when the browser was blocked on a modal dialog, ...

10 years, 2 months ago (2010-09-29 16:23:52 UTC) #1

Bernhard Bauer

On 2010/09/29 16:26:28, TVL wrote: > lg LGTM as well. Can you add bugs 35275, ...

10 years, 2 months ago (2010-09-29 16:32:39 UTC) #3

Paweł Hajdan Jr.

10 years, 2 months ago (2010-09-29 16:34:27 UTC) #4

Done. And I think I'm going to close the last one if this patch lands
successfully.