Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Issue 3591017: git_cl_hooks: get cl fields vi git_cl accessors instead of using backquote (Closed)

Created:
10 years, 2 months ago by Mandeep Singh Baines
Modified:
9 years, 7 months ago
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

git_cl_hooks: get cl fields vi git_cl accessors instead of using backquote This is part 2 of a 2-part change which fixes a bug where git-cl hangs if ~/.codereview_upload_cookies does not exist. It is actually waiting on user input for email/password (but you don't see the prompt because it's happening in a subprocess). This is a do-over of http://codereview.chromium.org/3622002. Much thanks to Lei Zhang for fixing the bugs in the original CL. His fixup CL was http://codereview.chromium.org/3541019. BUG=none TEST=Verified that the hang is fixed. Wrote a quick pre-submit to test that issue and patchset are ints: http://codereview.chromium.org/3533020 Output: ** Presubmit Warnings ** Patchset is 1 Issue is 3533020 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61957

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M git_cl_hooks.py View 3 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mandeep Singh Baines
10 years, 2 months ago (2010-10-08 00:29:59 UTC) #1
M-A Ruel
10 years, 2 months ago (2010-10-08 01:08:41 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698