Issue 3590029: Better align heap snapshots contents with debugger info.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3590029: Better align heap snapshots contents with debugger info. (Closed)

Created:
10 years, 2 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Better align heap snapshots contents with debugger info. I created a heap snapshot in Chromium, and then started comparing it side-by-side with representations of objects provided by the debugger, fixing discrepancies. Committed: http://code.google.com/p/v8/source/detail?r=5612

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -21 lines)			Patch
M	include/v8-profiler.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/objects.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/profile-generator.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/profile-generator.cc	View	6 chunks	+25 lines, -8 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	4 chunks	+3 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages