Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 359001: Revert 30938 - Add support for getting the real process id from within the su... (Closed)

Created:
11 years, 1 month ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam, ben+cc_chromium.org
Visibility:
Public.

Description

Revert 30938 - Add support for getting the real process id from within the suid sandbox. The browser processes gets the real process ids, so they look correct in the task manager. When it asks the zygote to reap a process, we use the process ids internal to the sandbox. While we are at it, reap the sandbox process after it clones the zygote and figure out zygote's actual process id. Save the actual process id rather than that of the sandbox. BUG=20012, 20714, 23072 TEST=Process IDs for renderers should be correct in the task manager and you should be able to use the end process button to kill them. Review URL: http://codereview.chromium.org/262020 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30939

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -300 lines) Patch
M base/linux_util.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/chrome_dll_main.cc View 6 chunks +5 lines, -28 lines 0 comments Download
MM chrome/browser/renderer_host/render_sandbox_host_linux.h View 3 chunks +3 lines, -14 lines 0 comments Download
M chrome/browser/renderer_host/render_sandbox_host_linux.cc View 12 chunks +14 lines, -66 lines 0 comments Download
MM chrome/browser/zygote_host_linux.h View 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/zygote_host_linux.cc View 7 chunks +23 lines, -70 lines 0 comments Download
M chrome/browser/zygote_main_linux.cc View 10 chunks +26 lines, -107 lines 0 comments Download
M chrome/chrome.gyp View 2 chunks +5 lines, -5 lines 0 comments Download
MM chrome/common/sandbox_methods_linux.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Lei Zhang
11 years, 1 month ago (2009-11-04 04:22:40 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698