Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 3585003: Prepare push to trunk. Now working on version 2.4.8. (Closed)

Created:
10 years, 2 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry, Rico
CC:
v8-dev
Visibility:
Public.

Description

Prepare push to trunk. Now working on version 2.4.8. Committed: http://code.google.com/p/v8/source/detail?r=5562

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed typo. #

Patch Set 3 : Added reference to Webkit bug in ChangeLog. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M ChangeLog View 1 2 2 chunks +15 lines, -0 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
10 years, 2 months ago (2010-09-30 08:34:52 UTC) #1
Rico
Drive by http://codereview.chromium.org/3585003/diff/1/2 File ChangeLog (right): http://codereview.chromium.org/3585003/diff/1/2#newcode4 ChangeLog:4: the flag --max-old-space-sze to be in MB ...
10 years, 2 months ago (2010-09-30 08:38:51 UTC) #2
Erik Corry
10 years, 2 months ago (2010-09-30 09:11:28 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698