Issue 3584010: Add chrome.windows.update({focused:true});

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3584010: Add chrome.windows.update({focused:true}); (Closed)

Created:
10 years, 2 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
rafaelw

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Add chrome.windows.update({focused:true}); BUG=31434 TEST=browser_tests --gtest_filter=ExtensionApiTest.*Tabs Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61555

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -2 lines)			Patch
M	chrome/browser/extensions/extension_tabs_module.cc	View	1 chunk	+11 lines, -1 line	0 comments	Download
M	chrome/common/extensions/api/extension_api.json	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/tabs/basics/test.js	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rafaelw

10 years, 2 months ago (2010-10-05 19:40:33 UTC) #2

lgtm. FYI, (and I realize how incredibly unhelpful this is), I feel like I tried
something like this way back in the day, but backed away from it -- but for the
life of me, I can't remember what the problem was. It's totally reasonable to
want this, and even if there is a problem, this is a good starting point. Just
be on the look out for side-effects.

Expand Messages | Collapse Messages