Issue 3582016: AU Payload Generator: allow extracting kernel/rootfs for debugging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3582016: AU Payload Generator: allow extracting kernel/rootfs for debugging (Closed)

Created:
10 years, 2 months ago by adlr

Modified:
9 years ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@chromiumos-git/crosutils.git

Visibility:
Public.

Description

AU Payload Generator: allow extracting kernel/rootfs for debugging BUG=7427 TEST=verified old style full and delta updates work Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=db0fa3f

Patch Set 2 : fix for review #

Patch Set 3 : fix for non-extract code paths #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -3 lines)			Patch
	M	cros_generate_update_payload	View	1 2	5 chunks	+38 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

petkov

LGTM w/ a nit. http://codereview.chromium.org/3582016/diff/1/2 File cros_generate_update_payload (right): http://codereview.chromium.org/3582016/diff/1/2#newcode100 cros_generate_update_payload:100: kern_out=$(mktemp /tmp/generate_update_payload.XXXXXX) There're no other ...

10 years, 2 months ago (2010-10-06 22:13:47 UTC) #2

adlr

Actually, I had to make another change for non-extract code paths that get the kernel/rootfs. ...

10 years, 2 months ago (2010-10-06 23:46:49 UTC) #3

LGTM