Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3350)

Unified Diff: chrome/browser/renderer_host/audio_renderer_host.cc

Issue 3581008: Fix instances of passing raw pointers to RefCounted objects in tasks. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Merge Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/audio_renderer_host.cc
diff --git a/chrome/browser/renderer_host/audio_renderer_host.cc b/chrome/browser/renderer_host/audio_renderer_host.cc
index 96b4999ee44cd37b201fa9c886925a7123b34d67..efe0d957cd1f9689b6ae713ae26e38a59b875257 100644
--- a/chrome/browser/renderer_host/audio_renderer_host.cc
+++ b/chrome/browser/renderer_host/audio_renderer_host.cc
@@ -121,39 +121,54 @@ void AudioRendererHost::IPCChannelClosing() {
// media::AudioOutputController::EventHandler implementations.
void AudioRendererHost::OnCreated(media::AudioOutputController* controller) {
ChromeThread::PostTask(
- ChromeThread::IO, FROM_HERE,
- NewRunnableMethod(this, &AudioRendererHost::DoCompleteCreation,
- controller));
+ ChromeThread::IO,
+ FROM_HERE,
+ NewRunnableMethod(
+ this,
+ &AudioRendererHost::DoCompleteCreation,
+ make_scoped_refptr(controller)));
}
void AudioRendererHost::OnPlaying(media::AudioOutputController* controller) {
ChromeThread::PostTask(
- ChromeThread::IO, FROM_HERE,
- NewRunnableMethod(this, &AudioRendererHost::DoSendPlayingMessage,
- controller));
+ ChromeThread::IO,
+ FROM_HERE,
+ NewRunnableMethod(
+ this,
+ &AudioRendererHost::DoSendPlayingMessage,
+ make_scoped_refptr(controller)));
}
void AudioRendererHost::OnPaused(media::AudioOutputController* controller) {
ChromeThread::PostTask(
- ChromeThread::IO, FROM_HERE,
- NewRunnableMethod(this, &AudioRendererHost::DoSendPausedMessage,
- controller));
+ ChromeThread::IO,
+ FROM_HERE,
+ NewRunnableMethod(
+ this,
+ &AudioRendererHost::DoSendPausedMessage,
+ make_scoped_refptr(controller)));
}
void AudioRendererHost::OnError(media::AudioOutputController* controller,
int error_code) {
ChromeThread::PostTask(
- ChromeThread::IO, FROM_HERE,
- NewRunnableMethod(this, &AudioRendererHost::DoHandleError,
- controller, error_code));
+ ChromeThread::IO,
+ FROM_HERE,
+ NewRunnableMethod(this,
+ &AudioRendererHost::DoHandleError,
+ make_scoped_refptr(controller),
+ error_code));
}
void AudioRendererHost::OnMoreData(media::AudioOutputController* controller,
AudioBuffersState buffers_state) {
ChromeThread::PostTask(
- ChromeThread::IO, FROM_HERE,
- NewRunnableMethod(this, &AudioRendererHost::DoRequestMoreData,
- controller, buffers_state));
+ ChromeThread::IO,
+ FROM_HERE,
+ NewRunnableMethod(this,
+ &AudioRendererHost::DoRequestMoreData,
+ make_scoped_refptr(controller),
+ buffers_state));
}
void AudioRendererHost::DoCompleteCreation(

Powered by Google App Engine
This is Rietveld 408576698