chrome/browser/download/save_package.cc - Issue 3581008: Fix instances of passing raw pointers to RefCounted objects in tasks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/save_package.cc

Issue 3581008: Fix instances of passing raw pointers to RefCounted objects in tasks. (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: Merge Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/save_package.cc

diff --git a/chrome/browser/download/save_package.cc b/chrome/browser/download/save_package.cc

index 4ce3e36b6e550d005a55edacfe1448ac6583894b..071e95b5536ce4aa3347104696e640f6ea38f06b 100644

--- a/chrome/browser/download/save_package.cc

+++ b/chrome/browser/download/save_package.cc

@@ -1025,8 +1025,7 @@ void SavePackage::OnReceivedSerializedHtmlData(const GURL& frame_url,

if (!data.empty()) {

// Prepare buffer for saving HTML data.

- net::IOBuffer* new_data = new net::IOBuffer(data.size());

- new_data->AddRef(); // We'll pass the buffer to SaveFileManager.

+ scoped_refptr<net::IOBuffer> new_data = new net::IOBuffer(data.size());

memcpy(new_data->data(), data.data(), data.size());

// Call write file functionality in file thread.