Chrome OS: make language per user.

chrome/browser/chromeos/login/login_utils.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/login_utils.h"
 
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/lock.h"
 #include "base/path_service.h"
 #include "base/scoped_ptr.h"
 #include "base/singleton.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_init.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browser_thread.h"
 #include "chrome/browser/chromeos/boot_times_loader.h"
 #include "chrome/browser/chromeos/cros/login_library.h"
 #include "chrome/browser/chromeos/cros/network_library.h"
 #include "chrome/browser/chromeos/external_cookie_handler.h"
 #include "chrome/browser/chromeos/input_method/input_method_util.h"
 #include "chrome/browser/chromeos/login/cookie_fetcher.h"
 #include "chrome/browser/chromeos/login/google_authenticator.h"
+#include "chrome/browser/chromeos/login/language_switch_menu.h"
 #include "chrome/browser/chromeos/login/ownership_service.h"
 #include "chrome/browser/chromeos/login/parallel_authenticator.h"
 #include "chrome/browser/chromeos/login/user_image_downloader.h"
 #include "chrome/browser/chromeos/login/user_manager.h"
 #include "chrome/browser/extensions/extensions_service.h"
 #include "chrome/browser/net/gaia/token_service.h"
 #include "chrome/browser/net/preconnect.h"
 #include "chrome/browser/prefs/pref_member.h"
 #include "chrome/browser/profile.h"
 #include "chrome/browser/profile_manager.h"
 #include "chrome/browser/sync/profile_sync_service.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/logging_chrome.h"
 #include "chrome/common/net/gaia/gaia_auth_fetcher.h"
 #include "chrome/common/net/gaia/gaia_constants.h"
 #include "chrome/common/net/url_request_context_getter.h"
 #include "chrome/common/pref_names.h"
 #include "googleurl/src/gurl.h"
 #include "net/base/cookie_store.h"
 #include "net/url_request/url_request_context.h"
 #include "views/widget/widget_gtk.h"
 
 namespace chromeos {
 
 namespace {
 
-// Prefix for Auth token received from ClientLogin request.
+// Affixes for Auth token received from ClientLogin request.
 const char kAuthPrefix[] = "Auth=";
-// Suffix for Auth token received from ClientLogin request.
 const char kAuthSuffix[] = "\n";
 
 // Increase logging level for Guest mode to avoid LOG(INFO) messages in logs.
 const char kGuestModeLoggingLevel[] = "1";
 
 // Format of command line switch.
 const char kSwitchFormatString[] = "--%s=\"%s\"";
 
 }  // namespace
 
@@ skipping 134 matching lines @@
     if (cryptohome->TpmIsEnabled() && !cryptohome->TpmIsBeingOwned()) {
       if (cryptohome->TpmIsOwned()) {
         cryptohome->TpmClearStoredPassword();
       } else {
         cryptohome->TpmCanAttemptOwnership();
       }
     }
   }
   btl->AddLoginTimeMarker("TPMOwned", false);
 
+  std::string pref_locale = profile->GetPrefs()->GetString(

[Nikita (slow), 2010/11/13 10:36:59]

Please extract into a separate method.
CompleteLogin now is 140 lines long.

[Denis Lagno, 2010/11/13 12:48:23]

Done.

+      prefs::kApplicationLocale);
+  if (pref_locale.empty()) {
+    if (first_login) {

[Nikita (slow), 2010/11/13 10:36:59]

How do you intend to bootstrap this option to the existing users?
They would always have an empty preference?

[Denis Lagno, 2010/11/13 12:48:23]

yes, I think check for first login does not resolve anything here.

[Nikita (slow), 2010/11/15 07:54:41]

Agree, there's one more thing remaining - conflicting with sync preference but
let's iterate in the future CLs.

+      profile->GetPrefs()->SetString(

[Nikita (slow), 2010/11/13 10:36:59]

As I understand we're always forcing language selected at Sign In pod to a user
profile.

What happens if user has this option set in his sync profile?
TODO/comment here.

[Denis Lagno, 2010/11/13 12:48:23]

Done.

+          prefs::kApplicationLocale,
+          g_browser_process->GetApplicationLocale());
+    }
+  } else {
+    LanguageSwitchMenu::SwitchLanguage(pref_locale);
+  }
+
   static const char kFallbackInputMethodLocale[] = "en-US";
   if (first_login) {
     std::string locale(g_browser_process->GetApplicationLocale());
     // Add input methods based on the application locale when the user first
     // logs in. For instance, if the user chooses Japanese as the UI
     // language at the first login, we'll add input methods associated with
     // Japanese, such as mozc.
     if (locale != kFallbackInputMethodLocale) {
       StringPrefMember language_preload_engines;
       language_preload_engines.Init(prefs::kLanguagePreloadEngines,
@@ skipping 161 matching lines @@
   BrowserInit browser_init;
   int return_code;
   browser_init.LaunchBrowser(*CommandLine::ForCurrentProcess(),
                              profile,
                              FilePath(),
                              true,
                              &return_code);
 }
 
 }  // namespace chromeos