Cashew: track cellular service state.

Cashew: track cellular service state.

BUG=chromium-os:7190
TEST=libcros/monitor_network and manual testing, observing cashew logs

Change-Id: I60a175f72dc665e12ab0eaa1c87054ad4c2dfe8b

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f727fe5

[Jason Glasgow, 2010-10-05 19:55:30]

http://codereview.chromium.org/3576011/diff/1/17
File src/service.cc (right):

http://codereview.chromium.org/3576011/diff/1/17#newcode28
src/service.cc:28: static const char* kFlimflamServiceStateFailure = "failure";
need activation_failure (or similar)

http://codereview.chromium.org/3576011/diff/1/18
File src/service.h (right):

http://codereview.chromium.org/3576011/diff/1/18#newcode44
src/service.h:44: kStateFailure,
already out for date w.r.t flimflam

[Vince Laviano, 2010-10-06 00:31:32]

http://codereview.chromium.org/3576011/diff/1/17
File src/service.cc (right):

http://codereview.chromium.org/3576011/diff/1/17#newcode28
src/service.cc:28: static const char* kFlimflamServiceStateFailure = "failure";
On 2010/10/05 19:55:30, Jason Glasgow wrote:
> need activation_failure (or similar)

Done. Added kFlimflamServiceStateActivationFailure and modified StateFromString
method to handle it.

http://codereview.chromium.org/3576011/diff/1/18
File src/service.h (right):

http://codereview.chromium.org/3576011/diff/1/18#newcode44
src/service.h:44: kStateFailure,
On 2010/10/05 19:55:30, Jason Glasgow wrote:
> already out for date w.r.t flimflam

Fixed. Added kStateActivationFailure enum value.

[Vince Laviano, 2010-10-06 04:17:50]

I discovered during testing that Cashew receives SIGABRT when it makes a D-Bus
GetProperties() method call to Flimflam when Flimflam is not running.  

I investigated and determined that the SIGABRTs were due to uncaught exceptions
from dbus-c++.

src/third_party/dbus-c++/README.chromiumos states "This is the DBus-C++ project,
modified to not require exceptions."
This seems to be... not the case.

I've uploaded a new patchset that wraps the GetProperties() dbus-c++ calls with
try-catch blocks.

See also the comments in the code.

[Jason Glasgow, 2010-10-06 18:23:12]

LGTM.  It would be better to fix dbus-C++ so that our code can follow Google
Style guidelines, but given our schedule that is unreasonable.

[Jason Glasgow, 2010-10-06 20:42:04]

LGTM (for the changes that make logging less verbose)