Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 3575015: entd: add libdl for dlopen and friends (Closed)

Created:
10 years, 2 months ago by rginda
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, rginda, gauravsh
Visibility:
Public.

Description

entd: add libdl for dlopen and friends This is needed by libcrosapi. A cleaner fix would be to add a pkgconfig to libcrosapi, which entd would use to determine its dependencies, but this is much more expedient. Change-Id: Idfedcd3c3025a64e836b3e65e8c3d9bfb24998ee BUG=None TEST=re-make entd in chroot, verify that -ldl appears in linker command line Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=5c9f711

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M SConstruct View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rginda
10 years, 2 months ago (2010-10-05 21:14:24 UTC) #1
Chris Masone
LGTM On Tue, Oct 5, 2010 at 2:14 PM, <rginda@chromium.org> wrote: > Reviewers: zel, Chris ...
10 years, 2 months ago (2010-10-05 21:16:53 UTC) #2
zel
10 years, 2 months ago (2010-10-05 21:20:05 UTC) #3
LGTM

derat@, can you do the similar fix for WM? i think we were missing pthreads on
that one

Powered by Google App Engine
This is Rietveld 408576698