src/x64/ic-x64.cc - Issue 3574002: Rename some x64 macros to be more precise about their semantics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/ic-x64.cc

Issue 3574002: Rename some x64 macros to be more precise about their semantics. (Closed)

Patch Set: Addressing Lasse's comments Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/ic-x64.cc

diff --git a/src/x64/ic-x64.cc b/src/x64/ic-x64.cc

index 814da760c88abab20e1226a08efbae6592c08448..a76ba463e9ba1f0b408fdb84c57fc5f5af40b515 100644

--- a/src/x64/ic-x64.cc

+++ b/src/x64/ic-x64.cc

@@ -895,7 +895,7 @@ void KeyedLoadIC::GenerateIndexedInterceptor(MacroAssembler* masm) {

// Check that the key is an array index, that is Uint32.

STATIC_ASSERT(kSmiValueSize <= 32);

- __ JumpIfNotPositiveSmi(rax, &slow);

+ __ JumpUnlessNonNegativeSmi(rax, &slow);

// Get the map of the receiver.

__ movq(rcx, FieldOperand(rdx, HeapObject::kMapOffset));

« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | src/x64/macro-assembler-x64.h » ('j') | no next file with comments »