Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 3573006: Replace last remaining usage of WebURLLoaderClient::didFinishLoading(WebURLLoader*) (Closed)

Created:
10 years, 2 months ago by Mihai Parparita -not on Chrome
Modified:
9 years, 6 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Replace last remaining usage of WebURLLoaderClient::didFinishLoading(WebURLLoader*) with WebURLLoaderClient::didFinishLoading(WebURLLoader*, double), so that the former can be removed. BUG=None TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61206

Patch Set 1 #

Total comments: 1

Patch Set 2 : Replace last remaining usage of WebURLLoaderClient::didFinishLoading(WebURLLo... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webkit/support/weburl_loader_mock.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mihai Parparita -not on Chrome
10 years, 2 months ago (2010-09-29 22:49:21 UTC) #1
pfeldman
LGTM with comment. Thanks for fixing this. http://codereview.chromium.org/3573006/diff/1/2 File webkit/support/weburl_loader_mock.cc (right): http://codereview.chromium.org/3573006/diff/1/2#newcode34 webkit/support/weburl_loader_mock.cc:34: client_->didFinishLoading(this, base::Time::Now().ToDoubleT()); ...
10 years, 2 months ago (2010-09-30 07:00:06 UTC) #2
Mihai Parparita -not on Chrome
10 years, 2 months ago (2010-10-01 18:37:53 UTC) #3
On Thu, Sep 30, 2010 at 12:00 AM,  <pfeldman@chromium.org> wrote:
> FYI: You can also pass "0" here since WebCore will interpret it as
> "There is no additional information on finish time available in the
> network stack, use current time".

Makes sense, changed to 0 and submitted.

Mihai

Powered by Google App Engine
This is Rietveld 408576698