Issue 3573006: Replace last remaining usage of WebURLLoaderClient::didFinishLoading(WebURLLoader*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3573006: Replace last remaining usage of WebURLLoaderClient::didFinishLoading(WebURLLoader*) (Closed)

Created:
10 years, 2 months ago by Mihai Parparita -not on Chrome

Modified:
9 years, 6 months ago

Reviewers:
pfeldman

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Replace last remaining usage of WebURLLoaderClient::didFinishLoading(WebURLLoader*) with WebURLLoaderClient::didFinishLoading(WebURLLoader*, double), so that the former can be removed. BUG=None TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61206

Patch Set 1 #

Total comments: 1

Patch Set 2 : Replace last remaining usage of WebURLLoaderClient::didFinishLoading(WebURLLo... #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	webkit/support/weburl_loader_mock.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pfeldman

LGTM with comment. Thanks for fixing this. http://codereview.chromium.org/3573006/diff/1/2 File webkit/support/weburl_loader_mock.cc (right): http://codereview.chromium.org/3573006/diff/1/2#newcode34 webkit/support/weburl_loader_mock.cc:34: client_->didFinishLoading(this, base::Time::Now().ToDoubleT()); ...

10 years, 2 months ago (2010-09-30 07:00:06 UTC) #2

Mihai Parparita -not on Chrome

10 years, 2 months ago (2010-10-01 18:37:53 UTC) #3

On Thu, Sep 30, 2010 at 12:00 AM,  <pfeldman@chromium.org> wrote:
> FYI: You can also pass "0" here since WebCore will interpret it as
> "There is no additional information on finish time available in the
> network stack, use current time".

Makes sense, changed to 0 and submitted.

Mihai

Expand Messages | Collapse Messages