Issue 3571009: metrics: Add guest mode detection to metrics library and client

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3571009: metrics: Add guest mode detection to metrics library and client (Closed)

Created:
10 years, 2 months ago by kmixter1

Modified:
9 years, 7 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, petkov, Luigi Semenzato, sosa

Base URL:
http://git.chromium.org/git/metrics.git

Visibility:
Public.

Description

metrics: Add guest mode detection to metrics library and client Change-Id: I2c27bd999330395ba3568820ea76198b202bd7f4 BUG=7203 TEST=Verify metrics_client -c and -g toggling consent and guest mode. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=eb5cff3

Patch Set 1 #

Patch Set 2 : Fix metrics_client semantics bug #

Total comments: 3

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+253 lines, -59 lines)			Patch
M	metrics_client.cc	View	1	2 chunks	+108 lines, -56 lines	0 comments	Download
M	metrics_daemon.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	metrics_library.h	View		2 chunks	+12 lines, -0 lines	1 comment	Download
M	metrics_library.cc	View		1 chunk	+71 lines, -1 line	2 comments	Download
M	metrics_library_test.cc	View		3 chunks	+62 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

10 years, 2 months ago (2010-10-01 16:13:08 UTC) #2

LGTM w/ a few nits/suggestions.

http://codereview.chromium.org/3571009/diff/2001/3003
File metrics_library.cc (right):

http://codereview.chromium.org/3571009/diff/2001/3003#newcode53
metrics_library.cc:53: return false;
indent is off?

http://codereview.chromium.org/3571009/diff/2001/3003#newcode62
metrics_library.cc:62: int match_state = 0;
If you rename match_state to match_index or match_offset, it will be almost
self-explanatory.

http://codereview.chromium.org/3571009/diff/2001/3004
File metrics_library.h (right):

http://codereview.chromium.org/3571009/diff/2001/3004#newcode90
metrics_library.h:90: char* buffer, int buffer_size,
the buffer is allocated on the stack anyway. you may as well allocate it inside
IsDeviceMounted and remove it from the method prototype. This will also
eliminate some NULL checking code and extra testing.

Expand Messages | Collapse Messages