Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: media/audio/win/audio_output_win_unittest.cc

Issue 357004: SetVolume and GetVolume take one volume instead of separate left and right vo... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/mac/audio_output_mac_unittest.cc ('k') | media/audio/win/waveout_output_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/win/audio_output_win_unittest.cc
===================================================================
--- media/audio/win/audio_output_win_unittest.cc (revision 30948)
+++ media/audio/win/audio_output_win_unittest.cc (working copy)
@@ -303,7 +303,7 @@
EXPECT_GT(test_triple_buffer.callback_count(), kNumBuffers);
EXPECT_FALSE(test_triple_buffer.had_error());
oas->Stop();
- ::Sleep(1000);
+ ::Sleep(500);
oas->Close();
}
@@ -325,11 +325,11 @@
// The test parameters cause a callback every 32 ms and the source is
// sleeping for 90 ms, so it is guaranteed that we run out of ready buffers.
oas->Start(&test_laggy);
- ::Sleep(1000);
+ ::Sleep(500);
EXPECT_GT(test_laggy.callback_count(), 2);
EXPECT_FALSE(test_laggy.had_error());
oas->Stop();
- ::Sleep(1000);
+ ::Sleep(500);
oas->Close();
}
@@ -353,9 +353,9 @@
size_t bytes_100_ms = (AudioManager::kAudioCDSampleRate / 10) * 2;
EXPECT_TRUE(oas->Open(bytes_100_ms));
- oas->SetVolume(1.0, 1.0);
+ oas->SetVolume(1.0);
- for (int ix = 0; ix != 25; ++ix) {
+ for (int ix = 0; ix != 5; ++ix) {
oas->Start(&source);
::Sleep(10);
oas->Stop();
@@ -364,7 +364,7 @@
}
-// This test produces actual audio for 1.5 seconds on the default wave
+// This test produces actual audio for .5 seconds on the default wave
// device at 44.1K s/sec. Parameters have been chosen carefully so you should
// not hear pops or noises while the sound is playing.
TEST(WinAudioTest, PCMWaveStreamPlay200HzTone44Kss) {
@@ -384,14 +384,14 @@
size_t bytes_100_ms = (AudioManager::kAudioCDSampleRate / 10) * 2;
EXPECT_TRUE(oas->Open(bytes_100_ms));
- oas->SetVolume(1.0, 1.0);
+ oas->SetVolume(1.0);
oas->Start(&source);
- ::Sleep(1500);
+ ::Sleep(500);
oas->Stop();
oas->Close();
}
-// This test produces actual audio for for 1.5 seconds on the default wave
+// This test produces actual audio for for .5 seconds on the default wave
// device at 22K s/sec. Parameters have been chosen carefully so you should
// not hear pops or noises while the sound is playing. The audio also should
// sound with a lower volume than PCMWaveStreamPlay200HzTone44Kss.
@@ -413,18 +413,15 @@
EXPECT_TRUE(oas->Open(bytes_100_ms));
- oas->SetVolume(0.5, 0.5);
+ oas->SetVolume(0.5);
oas->Start(&source);
- ::Sleep(1500);
+ ::Sleep(500);
// Test that the volume is within the set limits.
- double left_volume = 0.0;
- double right_volume = 0.0;
- oas->GetVolume(&left_volume, &right_volume);
- EXPECT_LT(left_volume, 0.51);
- EXPECT_GT(left_volume, 0.49);
- EXPECT_LT(right_volume, 0.51);
- EXPECT_GT(right_volume, 0.49);
+ double volume = 0.0;
+ oas->GetVolume(&volume);
+ EXPECT_LT(volume, 0.51);
+ EXPECT_GT(volume, 0.49);
oas->Stop();
oas->Close();
}
@@ -479,14 +476,14 @@
}
// Play a little bit more of the file.
- ::Sleep(4000);
+ ::Sleep(500);
oas->Stop();
oas->Close();
}
// This test is to make sure an AudioOutputStream can be started after it was
-// stopped. You will here two 1.5 seconds wave signal separated by 0.5 seconds
+// stopped. You will here two .5 seconds wave signal separated by 0.5 seconds
// of silence.
TEST(WinAudioTest, PCMWaveStreamPlayTwice200HzTone44Kss) {
if (IsRunningHeadless())
@@ -505,19 +502,19 @@
size_t bytes_100_ms = (AudioManager::kAudioCDSampleRate / 10) * 2;
EXPECT_TRUE(oas->Open(bytes_100_ms));
- oas->SetVolume(1.0, 1.0);
+ oas->SetVolume(1.0);
- // Play the wave for 1.5 seconds.
+ // Play the wave for .5 seconds.
oas->Start(&source);
- ::Sleep(1500);
+ ::Sleep(500);
oas->Stop();
// Sleep to give silence after stopping the AudioOutputStream.
- ::Sleep(500);
+ ::Sleep(250);
- // Start again and play for 1.5 seconds.
+ // Start again and play for .5 seconds.
oas->Start(&source);
- ::Sleep(1500);
+ ::Sleep(500);
oas->Stop();
oas->Close();
« no previous file with comments | « media/audio/mac/audio_output_mac_unittest.cc ('k') | media/audio/win/waveout_output_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698