Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: third_party/sqlite/README.chromium

Issue 3570009: Update sqlite's README.chromium with a note to keep webkit side (Closed)
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/sqlite/README.chromium
diff --git a/third_party/sqlite/README.chromium b/third_party/sqlite/README.chromium
index 2ac741595e728782dfad271f1ec1eeddf9f56003..926abd791e5be93466ec6c414bc1ff17eeca086e 100644
--- a/third_party/sqlite/README.chromium
+++ b/third_party/sqlite/README.chromium
@@ -42,6 +42,11 @@ cd sqlite
# Run the google_generate_preprocessed.sh script:
./google_generate_preprocessed.sh
+# If there are any updates to os_unix.c, remember to keep
+# WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp in sync.
+# This means preparing a separate patch for WebKit.
+# If you have questions about this part, ask phajdan.jr and dumi.
+
# Find a sucker. Send review.
# TODO(shess) Describe an appropriate comment style. Seems like it
# should at least include the SQLite version number.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698