Issue 3570009: Update sqlite's README.chromium with a note to keep webkit side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3570009: Update sqlite's README.chromium with a note to keep webkit side (Closed)

Created:
10 years, 2 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
dumi, Scott Hess - ex-Googler

CC:
chromium-reviews

Visibility:
Public.

Description

Update sqlite's README.chromium with a note to keep webkit side in sync. BUG=22208 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62151

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	third_party/sqlite/README.chromium	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

10 years, 2 months ago (2010-10-05 13:00:05 UTC) #2

LGTM

On Tue, Oct 5, 2010 at 5:52 AM,  <phajdan.jr@chromium.org> wrote:
> Reviewers: dumi, shess,
>
> Description:
> Update sqlite's README.chromium with a note to keep webkit side
> in sync.
>
> BUG=22208
> TEST=none
>
> Please review this at http://codereview.chromium.org/3570009/show
>
> Affected files:
>  M third_party/sqlite/README.chromium
>
>
> Index: third_party/sqlite/README.chromium
> diff --git a/third_party/sqlite/README.chromium
> b/third_party/sqlite/README.chromium
> index
>
2ac741595e728782dfad271f1ec1eeddf9f56003..926abd791e5be93466ec6c414bc1ff17eeca086e
> 100644
> --- a/third_party/sqlite/README.chromium
> +++ b/third_party/sqlite/README.chromium
> @@ -42,6 +42,11 @@ cd sqlite
>  # Run the google_generate_preprocessed.sh script:
>  ./google_generate_preprocessed.sh
>
> +# If there are any updates to os_unix.c, remember to keep
> +# WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp in sync.
> +# This means preparing a separate patch for WebKit.
> +# If you have questions about this part, ask phajdan.jr and dumi.
> +
>  # Find a sucker.  Send review.
>  # TODO(shess) Describe an appropriate comment style.  Seems like it
>  # should at least include the SQLite version number.
>
>
>

Expand Messages | Collapse Messages