Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 3567017: Fix ProcessSingletonTest.StartupRaceCondition using default profile again. (Closed)

Created:
10 years, 2 months ago by mattm
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.
Base URL:
git://codf21.jail/chromium.git
Visibility:
Public.

Description

Fix ProcessSingletonTest.StartupRaceCondition using default profile again. Also, make it use test_launcher_utils::PrepareBrowserCommandLineForTests. BUG=none TEST=not flaky when running on my local machine Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61597

Patch Set 1 #

Total comments: 2

Patch Set 2 : use ARGUMENTS_ONLY #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -6 lines) Patch
M chrome/browser/process_singleton_uitest.cc View 1 7 chunks +30 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mattm
10 years, 2 months ago (2010-10-05 21:33:12 UTC) #1
Evan Martin
OK http://codereview.chromium.org/3567017/diff/1/2 File chrome/browser/process_singleton_uitest.cc (right): http://codereview.chromium.org/3567017/diff/1/2#newcode75 chrome/browser/process_singleton_uitest.cc:75: CommandLine standard_switches(FilePath("blarg")); CommandLine standard_switches(CommandLine::ARGUMENTS_ONLY)
10 years, 2 months ago (2010-10-05 21:40:48 UTC) #2
mattm
http://codereview.chromium.org/3567017/diff/1/2 File chrome/browser/process_singleton_uitest.cc (right): http://codereview.chromium.org/3567017/diff/1/2#newcode75 chrome/browser/process_singleton_uitest.cc:75: CommandLine standard_switches(FilePath("blarg")); On 2010/10/05 21:40:49, Evan Martin wrote: > ...
10 years, 2 months ago (2010-10-05 22:00:52 UTC) #3
Evan Martin
10 years, 2 months ago (2010-10-05 22:03:43 UTC) #4
On 2010/10/05 22:00:52, mattm wrote:
> Oh.  I saw that and thought "I want switches, not arguments".

Please rename it and send me the change :)

Powered by Google App Engine
This is Rietveld 408576698