Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 3567010: Add enabling of local account. This should get the suite_Smoke to go green on the pfq. (Closed)

Created:
10 years, 2 months ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
scottz
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Add enabling of local account. This should get the suite_Smoke to go green on the pfq. Change-Id: Id480f45836a81d7d994b92d7a45d16208e1dd11c BUG= TEST=Ran locally. Saw all tests pass. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3ede50e

Patch Set 1 #

Patch Set 2 : move earlier #

Patch Set 3 : Fix RunCommand #

Patch Set 4 : Disable smoke on pineview #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M bin/cbuildbot.py View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M bin/cbuildbot_config.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
sosa
10 years, 2 months ago (2010-10-01 20:12:13 UTC) #1
scottz
LGTM
10 years, 2 months ago (2010-10-01 21:08:46 UTC) #2
sosa
10 years, 2 months ago (2010-10-01 21:12:06 UTC) #3
Filed issue http://code.google.com/p/chromium-os/issues/detail?id=7270
to fix pineview bin.  I'll watch the pfq for another day or so once we
go green and turn off error_ok=True so that the bvt's break the tree.

-Sosa

On Fri, Oct 1, 2010 at 2:08 PM,  <scottz@chromium.org> wrote:
> LGTM
>
> http://codereview.chromium.org/3567010/show
>

Powered by Google App Engine
This is Rietveld 408576698