Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 3566003: Introduce subclasses of class CompilationInfo. (Closed)

Created:
10 years, 2 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Introduce subclasses of class CompilationInfo. It was a wart that we had three handle fields, exactly one of which was non-null; and that we had three overloaded constructors. Instead, introduce subclasses and virtual methods. Remove some unused fields from class CompilationInfo. Committed: http://code.google.com/p/v8/source/detail?r=5560

Patch Set 1 #

Patch Set 2 : Fix two small mistakes. #

Patch Set 3 : Rebased to HEAD. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -76 lines) Patch
M src/compiler.h View 1 2 1 chunk +79 lines, -64 lines 0 comments Download
M src/compiler.cc View 4 chunks +9 lines, -7 lines 2 comments Download
M src/handles.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/liveedit.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Kevin Millikin (Chromium)
10 years, 2 months ago (2010-09-29 17:59:17 UTC) #1
Kevin Millikin (Chromium)
Søren, do you have time to take a look at this?
10 years, 2 months ago (2010-09-30 08:14:53 UTC) #2
Søren Thygesen Gjesse
LGTM http://codereview.chromium.org/3566003/diff/5001/6001 File src/compiler.cc (right): http://codereview.chromium.org/3566003/diff/5001/6001#newcode184 src/compiler.cc:184: info.set_function(lit); Why not pass the function literal to ...
10 years, 2 months ago (2010-09-30 08:41:49 UTC) #3
Kevin Millikin (Google)
10 years, 2 months ago (2010-09-30 08:47:21 UTC) #4
http://codereview.chromium.org/3566003/diff/5001/6001
File src/compiler.cc (right):

http://codereview.chromium.org/3566003/diff/5001/6001#newcode184
src/compiler.cc:184: info.set_function(lit);
On 2010/09/30 08:41:49, Søren Gjesse wrote:
> Why not pass the function literal to the EagerCompilationInfo constructor? It
> seems to always set when constructing an EagerCompilationInfo anyway.

I plan to refactor the parser entry points to take the CompilationInfo and fill
in its FunctionLiteral.

Powered by Google App Engine
This is Rietveld 408576698