Introduce subclasses of class CompilationInfo.

Introduce subclasses of class CompilationInfo.

It was a wart that we had three handle fields, exactly one of which
was non-null; and that we had three overloaded constructors.  Instead,
introduce subclasses and virtual methods.

Remove some unused fields from class CompilationInfo.

Committed: http://code.google.com/p/v8/source/detail?r=5560

[Kevin Millikin (Chromium), 2010-09-30 08:14:53]

Søren, do you have time to take a look at this?

[Søren Thygesen Gjesse, 2010-09-30 08:41:49]

LGTM

http://codereview.chromium.org/3566003/diff/5001/6001
File src/compiler.cc (right):

http://codereview.chromium.org/3566003/diff/5001/6001#newcode184
src/compiler.cc:184: info.set_function(lit);
Why not pass the function literal to the EagerCompilationInfo constructor? It
seems to always set when constructing an EagerCompilationInfo anyway.

[Kevin Millikin (Google), 2010-09-30 08:47:21]

http://codereview.chromium.org/3566003/diff/5001/6001
File src/compiler.cc (right):

http://codereview.chromium.org/3566003/diff/5001/6001#newcode184
src/compiler.cc:184: info.set_function(lit);
On 2010/09/30 08:41:49, Søren Gjesse wrote:
> Why not pass the function literal to the EagerCompilationInfo constructor? It
> seems to always set when constructing an EagerCompilationInfo anyway.

I plan to refactor the parser entry points to take the CompilationInfo and fill
in its FunctionLiteral.