Issue 3562011: Revert 61740 - Make BrowserAccessibilityManager cross platform. Step 2. ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3562011: Revert 61740 - Make BrowserAccessibilityManager cross platform. Step 2. ... (Closed)

Created:
10 years, 2 months ago by Chris Guillory

Modified:
9 years, 7 months ago

Reviewers:
Chris Guillory

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 61740 - Make BrowserAccessibilityManager cross platform. Step 2. 1. Move common logic and fields from BrowserAccessibilityMangerWin to BrowserAccessibilityManager. 2. Move common logic and fields from BrowserAccessibilityWin to BrowserAccessibility. Linux errors. BUG=55264 TEST=interactive_ui_tests:AccessibilityWinBrowserTest.* TEST=unit_tests:BrowserAccessibilityTest.* Review URL: http://codereview.chromium.org/3551015 TBR=ctguil@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61749

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+805 lines, -920 lines)			Patch
M	chrome/browser/accessibility/browser_accessibility.h	View	2 chunks	+1 line, -105 lines	0 comments	Download
M	chrome/browser/accessibility/browser_accessibility.cc	View	1 chunk	+0 lines, -94 lines	0 comments	Download
M	chrome/browser/accessibility/browser_accessibility_manager.h	View	2 chunks	+30 lines, -123 lines	0 comments	Download
M	chrome/browser/accessibility/browser_accessibility_manager.cc	View	2 chunks	+5 lines, -261 lines	0 comments	Download
M	chrome/browser/accessibility/browser_accessibility_manager_win.h	View	1 chunk	+110 lines, -14 lines	0 comments	Download
M	chrome/browser/accessibility/browser_accessibility_manager_win.cc	View	1 chunk	+274 lines, -45 lines	0 comments	Download
M	chrome/browser/accessibility/browser_accessibility_win.h	View	5 chunks	+82 lines, -23 lines	0 comments	Download
M	chrome/browser/accessibility/browser_accessibility_win.cc	View	29 chunks	+255 lines, -193 lines	0 comments	Download
M	chrome/browser/accessibility/browser_accessibility_win_unittest.cc	View	8 chunks	+43 lines, -53 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view.h	View	3 chunks	+1 line, -6 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_win.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_win.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages